Closed
Bug 540524
Opened 15 years ago
Closed 14 years ago
mozilla-plugin.pc.in still includes a stable in cflags
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(blocking1.9.2 -, status1.9.2 .13-fixed, status1.9.1 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking1.9.2 | --- | - |
status1.9.2 | --- | .13-fixed |
status1.9.1 | --- | unaffected |
People
(Reporter: anarchy, Assigned: anarchy)
Details
Attachments
(1 file)
397 bytes,
patch
|
benjamin
:
review+
christian
:
approval1.9.2.13+
christian
:
approval1.9.2.7-
|
Details | Diff | Splinter Review |
Headers are no longer declared stable/testing the stable dir via CFLAGS needs to be drop'd
Assignee | ||
Updated•15 years ago
|
Attachment #422281 -
Flags: review?(benjamin)
Assignee | ||
Updated•15 years ago
|
Flags: blocking1.9.2?
Updated•15 years ago
|
Attachment #422281 -
Attachment mime type: application/octet-stream → text/patch
Updated•15 years ago
|
Attachment #422281 -
Attachment mime type: text/patch → text/plain
Updated•15 years ago
|
Attachment #422281 -
Flags: review?(benjamin) → review+
Updated•15 years ago
|
blocking1.9.2: --- → ?
Flags: blocking1.9.2?
Comment 1•15 years ago
|
||
Don't think this blocks, but we'd take the patch on mozilla1.9.2 if nominated, I think.
blocking1.9.2: ? → -
status1.9.2:
--- → wanted
Updated•15 years ago
|
Component: XUL → Build Config
QA Contact: xptoolkit.widgets → build-config
Updated•15 years ago
|
Assignee: nobody → anarchy
Component: Build Config → XULRunner
Product: Core → Toolkit
QA Contact: build-config → xulrunner
Updated•15 years ago
|
Attachment #422281 -
Attachment is patch: true
Updated•15 years ago
|
Keywords: checkin-needed
Comment 2•15 years ago
|
||
You need to request approval for this to land on 1.9.2.
Keywords: checkin-needed
Assignee | ||
Updated•15 years ago
|
Attachment #422281 -
Flags: approval1.9.2.2?
Comment 3•14 years ago
|
||
Comment on attachment 422281 [details] [diff] [review] mozilla-plugin.pc.in-fix-cflags.patch Didn't make 1.9.2.3. Moving approval request out.
Attachment #422281 -
Flags: approval1.9.2.2? → approval1.9.2.3?
Comment 4•14 years ago
|
||
Er, didn't make 1.9.2.2.
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 5•14 years ago
|
||
fixed by http://hg.mozilla.org/mozilla-central/rev/8b297d7065d8
Comment 6•14 years ago
|
||
(In reply to comment #5) > fixed by http://hg.mozilla.org/mozilla-central/rev/8b297d7065d8 > > *** This bug has been marked as a duplicate of bug 488175 *** Except this is a 1.9.2 branch only problem, and has been since it was filed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•14 years ago
|
Attachment #422281 -
Flags: approval1.9.2.4? → approval1.9.2.5?
Comment on attachment 422281 [details] [diff] [review] mozilla-plugin.pc.in-fix-cflags.patch We will not be taking this for 3.6.6. Moving approval request forward. If you disagree, send me an email.
Attachment #422281 -
Flags: approval1.9.2.7?
Attachment #422281 -
Flags: approval1.9.2.6-
Attachment #422281 -
Flags: approval1.9.2.5?
Comment on attachment 422281 [details] [diff] [review] mozilla-plugin.pc.in-fix-cflags.patch a=LegNeato for 1.9.2.9.
Comment 9•14 years ago
|
||
Comment on attachment 422281 [details] [diff] [review] mozilla-plugin.pc.in-fix-cflags.patch Let's try again for next round.
Attachment #422281 -
Flags: approval1.9.2.12?
Attachment #422281 -
Flags: approval1.9.2.9?
Attachment #422281 -
Flags: approval1.9.2.12?
Attachment #422281 -
Flags: approval1.9.2.12+
Comment 10•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b24ae4b4b019
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
status1.9.1:
--- → unaffected
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•